Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (5790091) to head (913099d).
Report is 11 commits behind head on 4.20.

@@            Coverage Diff            @@
##               4.20   #11132   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13274    13278    +4     
=========================================
  Files          5657     5657           
  Lines        497898   497969   +71     
  Branches      60374    60388   +14     
=========================================
+ Hits          80441    80464   +23     
- Misses       408496   408541   +45     
- Partials       8961     8964    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14035

@blueorangutan test

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-13686)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54503 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11132-t13686-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

@shwstppr
can you review if this change makes sense or not ? thanks

@weizhouapache I'm not entirely sure about these changes (we discussed this earlier!?).
My understanding of the sslverification flag is that when set to true, it should enforce certificate validation—i.e., the webhook delivery service should validate the server's certificate using the trusted certificates available in the JRE.

However, with the current change, it seems we're using a "trust all" approach even when sslverification is set to true.

In my understanding, the correct way to test this would be to set up a server using self-signed certificates, explicitly add those certificates to the trusted store on the management server, and then verify that delivery works as expected when sslverification is set to true.

@weizhouapache I'm not entirely sure about these changes (we discussed this earlier!?).
My understanding of the sslverification flag is that when set to true, it should enforce certificate validation—i.e., the webhook delivery service should validate the server's certificate using the trusted certificates available in the JRE.

However, with the current change, it seems we're using a "trust all" approach even when sslverification is set to true.

In my understanding, the correct way to test this would be to set up a server using self-signed certificates, explicitly add those certificates to the trusted store on the management server, and then verify that delivery works as expected when sslverification is set to true.

@shwstppr thanks for the reply.
agree with your last paragraph, I think the best way is to implement the same behaviour as direct download , refer to #11113
However, then we have to manage the certificates (similar to direct download, but not on kvm host). I think trust all is the workaround , and it is the expected behavior currently. Without the change, the new test (https server) will fail.

@weizhouapache upto you. Without any change in Java code I feel the new test would fail because it is using a self-signed certificate and SSL verification is set to true. For the test or a user's use-case sslverification can be set to false which should allow delivery to work fine.

@weizhouapache upto you. Without any change in Java code I feel the new test would fail because it is using a self-signed certificate and SSL verification is set to true. For the test or a user's use-case sslverification can be set to false which should allow delivery to work fine.

Thanks @shwstppr

I understand a bit on your logic now.

• if ssl certfication is false, use trust all.
• if ssl cerification is true, use the default ssl trust store.

I think the logic is correct. Maybe one thing can be improved is, adding the cloudstack mangement store to trust store, so the https server which uses the certificate issued by cloudstack CA, such as the https server in the new test, can work.

I will update the PR (java code) so the logic will be kept, and new test with https server will pass too.

Thanks @weizhouapache. Make sense. Using something similar to what you've used in #11113 and then in the test, either using some existing certificate from MS or using uploadCustomCertificate.
Thanks for catching and improving this case

closing now
will revisit later